Skip to content

Remove unused recoverable argument in collect_intra_doc_links #131957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2024
Merged

Remove unused recoverable argument in collect_intra_doc_links #131957

merged 1 commit into from
Oct 20, 2024

Conversation

GuillaumeGomez
Copy link
Member

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Oct 20, 2024
@notriddle
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 20, 2024

📌 Commit 3e67fbd has been approved by notriddle

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 20, 2024
@bors
Copy link
Collaborator

bors commented Oct 20, 2024

⌛ Testing commit 3e67fbd with merge bfab34a...

@bors
Copy link
Collaborator

bors commented Oct 20, 2024

☀️ Test successful - checks-actions
Approved by: notriddle
Pushing bfab34a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 20, 2024
@bors bors merged commit bfab34a into rust-lang:master Oct 20, 2024
7 checks passed
@rustbot rustbot added this to the 1.84.0 milestone Oct 20, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (bfab34a): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -3.1%, secondary 3.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 3.1% [3.1%, 3.1%] 1
Improvements ✅
(primary)		 -3.1% [-3.1%, -3.1%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -3.1% [-3.1%, -3.1%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 780.931s -> 781.913s (0.13%)
Artifact size: 333.70 MiB -> 333.77 MiB (0.02%)

@GuillaumeGomez GuillaumeGomez deleted the rm-unused branch October 23, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@notriddle notriddle

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.84.0
Development

Successfully merging this pull request may close these issues.
5 participants
@GuillaumeGomez @notriddle @bors @rust-timer @rustbot